Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --match-replies-timeout to print messages without a reply. #1199

Closed
wants to merge 1 commit into from

Conversation

apollo13
Copy link

No description provided.

@@ -110,6 +111,7 @@ func configureSubCommand(app commandHost) {
// To be done - check for streams with WorkQueue, then prompt with or allow with override --force=WorkQueueDelete
// act.Flag("ackPolicy", "Acknowledgment policy (none, all, explicit) (requires JetStream)").Default("none").EnumVar(&c.ackPolicy, "none", "all", "explicit")
act.Flag("match-replies", "Match replies to requests").UnNegatableBoolVar(&c.match)
act.Flag("match-replies-timeout", "Timeout after which messages without a reply are printed").PlaceHolder("TIMEOUT").DurationVar(&c.matchTimeout)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to set this to a (low?) default.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather just use the overall timeout set with --timeout, dont think its needed add more ways to set timeouts. That one already have a default.

Still, I am not sure if I want to add this, will give it some thought.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you want it, then I'll adjust the PR. Otherwise feel free to close it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry fell below the radar during the holidays.

I think I'll pass on this for the moment, things get a bit complicated and hard to understand with every new flag and behaviour so want to be quite careful about it.

If others report similar concerns we can revisit, sorry about that.

@ripienaar ripienaar closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants